Draft
Fix keepalive readiness deadlock when sub-millisecond time remains#1004
Conversation
…xpiration Co-authored-by: fafhrd91 <598990+fafhrd91@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job stable - aarch64-apple-darwin
Fix keepalive readiness deadlock when sub-millisecond time remains
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS CI job timed out because
ntex-util services::keepalive::tests::test_kahung indefinitely (SLOW [>420.000s]until the 10-minute step timeout).KeepAliveService::ready()re-arms itsSleepwith the time remaining until expiration, truncated to whole milliseconds.now()is a low-resolution (5ms) clock, so the remainder is frequently sub-millisecond, producingSleep::reset(Millis(0)).TimerHandle::update_timertreats0as "clear the timer", leaving the sleep permanently elapsed — the subsequentpoll_elapsedreturnsReadyand registers no waker, so the dispatcher parks forever and readiness never resolves.Changes
ntex-util/src/services/keepalive.rsMillis(1)so a waker is always registered.ready()only returnsOkonce the timer is actually pending (orErrif the keep-alive expired in the meantime).test_ka_sub_millis, which forces the sub-millisecond state and asserts the timer is re-armed afterready().